dokan icon indicating copy to clipboard operation
dokan copied to clipboard

Seller Address Fix

Open fisher2470 opened this issue 11 months ago • 1 comments

Allows admin to hide street addresses across the site via a toggle in the appearance settings.

All Submissions:

  • [x] My code follow the WordPress' coding standards
  • [x] My code satisfies feature requirements
  • [x] My code is tested
  • [ ] My code passes the PHPCS tests
  • [ ] My code has proper inline documentation
  • [ ] I've included related pull request(s) (optional)
  • [ ] I've included developer documentation (optional)
  • [ ] I've added proper labels to this pull request

Changes proposed in this Pull Request:

This pull request implements the Street Address Toggle functionality mentioned in this issue: #2125

Closes

#2125

How to test the changes in this Pull Request:

Street Address toggle is added here: image

Toggling on, will hide the street address for all vendors on the store page as well as in the store listings.

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

  • [ ] Correct — Does the change do what it’s supposed to? ie: code 100% fulfilling the requirements?
  • [ ] Secure — Would a nefarious party find some way to exploit this change? ie: everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities?
  • [ ] Readable — Will your future self be able to understand this change months down the road?
  • [ ] Elegant — Does the change fit aesthetically within the overall style and architecture?

fisher2470 avatar Mar 04 '24 22:03 fisher2470

This solution is not optimal. We need to work on a more flexible solution regarding street address hiding by admins.

imtiaz-pranto avatar Apr 17 '24 11:04 imtiaz-pranto