dokan icon indicating copy to clipboard operation
dokan copied to clipboard

Update: Fontawesome library to version 6.5.1

Open Aunshon opened this issue 1 year ago • 1 comments

All Submissions:

  • [x] My code follow the WordPress' coding standards
  • [x] My code satisfies feature requirements
  • [x] My code is tested
  • [x] My code passes the PHPCS tests
  • [x] My code has proper inline documentation
  • [x] I've included related pull request(s) (optional)
  • [x] I've included developer documentation (optional)
  • [x] I've added proper labels to this pull request

Changes proposed in this Pull Request:

Update Fontawesome library to version 6.5.1 and change the twitter X icon

Related Pull Request(s)

  • Dokan Pro PR: https://github.com/getdokan/dokan-pro/pull/3030

Closes

  • Closes https://github.com/getdokan/dokan-pro/issues/2729

How to test the changes in this Pull Request:

  • Check if there is any icon broken for font awesome and check if the twitter X icon is updated everiwhere

Changelog entry

Update: Fontawesome library to version 6.5.1

PR Self Review Checklist:

  • Code is not following code style guidelines
  • Bad naming: make sure you would understand your code if you read it a few months from now.
  • KISS: Keep it simple, Sweetie (not stupid!).
  • DRY: Don't Repeat Yourself.
  • Code that is not readable: too many nested 'if's are a bad sign.
  • Performance issues
  • Complicated constructions that need refactoring or comments: code should almost always be self-explanatory.
  • Grammar errors.

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

  • [ ] Correct — Does the change do what it’s supposed to? ie: code 100% fulfilling the requirements?
  • [ ] Secure — Would a nefarious party find some way to exploit this change? ie: everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities?
  • [ ] Readable — Will your future self be able to understand this change months down the road?
  • [ ] Elegant — Does the change fit aesthetically within the overall style and architecture?

Aunshon avatar Jan 12 '24 06:01 Aunshon

https://files.slack.com/files-pri/T0ZBQ4T8S-F06D6167D47/image.png

One Twitter SVG Image Is needed

@tuhin480

Aunshon avatar Jan 12 '24 07:01 Aunshon

@Aunshon , Kindly Sync with develop

shashwatahalder01 avatar Feb 22 '24 06:02 shashwatahalder01