dokan icon indicating copy to clipboard operation
dokan copied to clipboard

🎨 fix: Single store page header style broken on multiple themes

Open devAsadNur opened this issue 1 year ago β€’ 4 comments

All Submissions:

  • [x] My code follows the WordPress' coding standards
  • [x] My code satisfies feature requirements
  • [x] My code is tested
  • [x] My code passes the PHPCS tests
  • [ ] My code has proper inline documentation
  • [ ] I've included developer documentation (optional)
  • [x] I've added proper labels to this pull request

Changes proposed in this Pull Request:

  • Closes https://github.com/getdokan/dokan-pro/issues/2742

How to test the changes in this Pull Request:

  • Please follow the steps from: https://github.com/getdokan/dokan-pro/issues/2742

Changelog entry

fix: Single store page header style broken on multiple themes

PR Self Review Checklist:

  • Code is not following code style guidelines
  • Bad naming: make sure you will understand your code if you read it a few months from now.
  • KISS: Keep it simple, Sweetie (not stupid!).
  • DRY: Don't Repeat Yourself.
  • Code that is not readable: too many nested 'if's are a bad sign.
  • Performance issues
  • Complicated constructions that need refactoring or comments: code should almost always be self-explanatory.
  • Grammar errors.

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

  • [ ] Correct β€” Does the change do what it’s supposed to? ie: code 100% fulfilling the requirements?
  • [ ] Secure β€” Would a nefarious party find some way to exploit this change? ie: everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities?
  • [ ] Readable β€” Will your future self be able to understand this change months down the road?
  • [ ] Elegant β€” Does the change fit aesthetically within the overall style and architecture?

devAsadNur avatar Oct 03 '23 03:10 devAsadNur

Scenario: The single store page header style is still broken for big image size

Steps to reproduce:

  1. set a bigger banner size e.g. 8000 x 8000
  2. upload an image with an extended height
  3. go to the single store page

Screenshot: Screenshot at Oct 04 11-41-52

shashwatahalder01 avatar Oct 04 '23 05:10 shashwatahalder01

Scenario: store open-close is not fully visible.

Steps to reproduce:

  1. set open store close for a vendor
  2. go to the single store list page for that vendor

Screenshot: Screenshot at Dec 15 16-29-18

shashwatahalder01 avatar Dec 15 '23 10:12 shashwatahalder01

Scenario: Design is broken for placeholder banner.

Steps to reproduce:

  1. set different layout and then go to single store page [store with default banner]

Screenshot: PR: Screenshot at Dec 15 14-38-12 Develop: Screenshot at Dec 15 14-39-13

PR: Screenshot at Dec 15 14-40-43

Develop: Screenshot at Dec 15 14-41-02

PR: Screenshot at Dec 15 14-41-51

Develop: Screenshot at Dec 15 14-42-20

PR: Screenshot at Dec 15 14-43-25

Develop: Screenshot at Dec 15 14-43-39

shashwatahalder01 avatar Dec 15 '23 10:12 shashwatahalder01

FYI This might also be related to this: https://github.com/getdokan/dokan/issues/2259

Sophie-2e avatar Apr 29 '24 13:04 Sophie-2e