getdns icon indicating copy to clipboard operation
getdns copied to clipboard
verified publisher icon getdnsapi

Fix Windows build

Open AstralStorm opened this issue 2 years ago • 5 comments

Fixes #537. Stubby will need an update once its service fix PR is merged.

AstralStorm avatar Jan 03 '23 13:01 AstralStorm

@wtoorop I've merged the related Stubby PR and updated the submodule. With the fixes in this PR everything builds on Windows again, so this can be merged if you are happy with it.

saradickinson avatar Jan 09 '23 16:01 saradickinson

@wtoorop I've merged the related Stubby PR and updated the submodule. With the fixes in this PR everything builds on Windows again, so this can be merged if you are happy with it.

Yes, will do, I just have to make sure the changes to gldns are also in upstream Unbound's sldns so they won't be reversed in the future again when syncing up with Unbound.

wtoorop avatar Jan 10 '23 07:01 wtoorop

We see this build failure in the update submitted by @jiayuehua . See https://github.com/microsoft/vcpkg/pull/34188

(As an aside it would be nice to have a variable we can turn off to disable generating docs instead of patching but that's unrelated)

BillyONeal avatar Oct 04 '23 00:10 BillyONeal

I note that their patch also guards for HAVE_TIME_H

BillyONeal avatar Oct 04 '23 01:10 BillyONeal

Any progress here?

MonicaLiu0311 avatar Nov 13 '23 07:11 MonicaLiu0311