wp-intervention icon indicating copy to clipboard operation
wp-intervention copied to clipboard

File name does not depend of quality

Open quentinneyraud opened this issue 5 years ago • 1 comments

Hello @getdave,

I'm trying to create a on-demand image resizing with Wordpress and your plugin helps me a lot 👍 .

I can access to URLs like this BASE_URL/app/uploads/2020/02/food-photographer-i-david-fedulov-X92WLoaQ1_o-unsplash.jpg/?width=500&quality=80 with different widths to generate and get different images but changing quality parameter always return the same image.

I think it is because quality parameter is never used in file name creation, so the cached version is returned.

Maybe it should be pushed to $args array here https://github.com/getdave/wp-intervention/blob/b5478fbc02122d893dabb18a618f473409036693/src/intervention-wrapper.php#L132-L149

Someting like :

$args['quality'] = $this->options['quality'];

on line 135.

I can make a PR or add detailed code if you want more infos on my use case.

quentinneyraud avatar Mar 23 '20 17:03 quentinneyraud

It is great to see you found this useful. Thanks for letting me know and taking the time to raise this Issue.

Yes i see the problem. That is correct and an oversight on my part.

I would love to see a PR. It would help me a lot.

getdave avatar Mar 27 '20 08:03 getdave