Do not store Password warning in db dump

[dbernar1]

Hello,

Thanks for sharing your software. I use mysql56 from homebrew on a Mac, and when dumping local db "Warning: Using a password on the command line interface can be insecure." is added to the dump file, and then import fails. The way I've solved it here is obviously not fancy, but it does the trick for me.

Let me know if you need any help with merging this in or testing other use cases if you don't have access to an environment where you can reproduce this.

[getdave]

Thanks for reporting this, it's much appreciated.

I'd be cautious of merging your fix as it looks like it's solving the symptom rather than than cause of the issue.

Perhaps a better fix would be to provide the user with the option to provide a call back function to enable them to run other custom tasks once the DUMP has completed. Then items such as this additional replace could be added without having to roll them into the main script.

I'd be interested in hearing your thoughts and would love to see a pull request!

Much appreciated!

[dbernar1]

Sure thing.

Would the user provide the callback inside the options section?

[getdave]

Sounds like a good idea. Haven't investigated if there's already a established convention for this in the Node/Grunt community though...

[nicooprat]

@dbernar1 Thanks for your quick fix !

@getdave Will you merge this anytime soon ?

[dbernar1]

@nicooprat You're most welcome :O)

[getdave]

@dbernar1 This is awesome. Thanks so much. Could you poss resubmit into the develop branch?

[dbernar1]

Hey Dave,

Sure, I've created #50. Let me know if you had something else in mind.

I'm curious - how come you changed your mind?

Thanks!