option autoPlay:false ignored

[Nebel54]

Thanks for the good work!

I stumbled into a bug today: The option autoPlay:false is ignored, because your initialize Method fires this.play() without considering this option, please wrap an if-statement around it:

    // let's get things going!
    if (this.autoPlay) {
        this.play();
    }

Thanks again, Oliver

[getdave]

Hi Oliver,

Many thanks for noticing this. It always helps when people take the time to report such things.

Thanks for submitting. I will do my best to get this fixed as soon as possible.

Many thanks,

David

On 29 August 2012 15:17, Nebel54 [email protected] wrote:

Thanks for the good work!

I stumbled into a bug today: The option autoPlay:false is ignored, because your initialize Method fires this.play() without considering this option, please wrap an if-statement around it:

// let's get things going!
if (this.autoPlay) {
    this.play();
}

Thanks again, Oliver

— Reply to this email directly or view it on GitHubhttps://github.com/getdave/Protoshow/issues/12.

[getdave]

Hi @Nebel54. Is there any way you could raise a pull request into the develop branch for this? Would be greatly appreciated.

[Nebel54]

Hi @getdave, i just initiated the pull request... hope the request works :)