brevo-php icon indicating copy to clipboard operation
brevo-php copied to clipboard

Fix Implicitly marking parameters TransactionalEmailsApi.php on php 8.4

Open fabricebegue opened this issue 1 year ago • 11 comments

On PHP 8.4 when we sent a transactional email, some deprecated messages are log

Message log detail : Deprecated: Brevo\Client\Api\TransactionalEmailsApi::__construct(): Implicitly marking parameter $client as nullable is deprecated, the explicit nullable type must be used instead in /var/www/app/vendor/getbrevo/brevo-php/lib/Api/TransactionalEmailsApi.php on line 72

fabricebegue avatar Jan 29 '25 14:01 fabricebegue

This pull request should be accepted in order to migrate to PHP 8.4
Thank you

sigkoro avatar Feb 11 '25 13:02 sigkoro

how can we get this merged, please advise on the process - this is creating a lot of noise in our log files

coatpont avatar Mar 02 '25 17:03 coatpont

This PR should fix https://github.com/getbrevo/brevo-php/issues/57.

But as stated by @LaurentBrieu in the above issue, this fix will break compatibility with PHP < 7.1 and as such, the minimum PHP version should be updated in composer.json and I guess this will require a major release.

Much needed indeed!

nclavaud avatar Mar 14 '25 14:03 nclavaud

+1 !

Renrhaf avatar Mar 17 '25 10:03 Renrhaf

+1

brei0x avatar Mar 25 '25 09:03 brei0x

+1!

Huluti avatar Mar 27 '25 10:03 Huluti

+1!

thomasfaure avatar Apr 17 '25 08:04 thomasfaure

@sowmyahora2001 @nik-sib @preetishishodia7 would you please consider merging this, stop supporting PHP 5.6/7.0, and tag a new version? :pray:

nclavaud avatar Apr 19 '25 09:04 nclavaud

I think commit https://github.com/getbrevo/brevo-php/commit/89b2fb859e56b79649ed10e5f7687b267ad4908c included in release v2.0.5 solved this issue.

nclavaud avatar May 26 '25 10:05 nclavaud

I think commit 89b2fb8 included in release v2.0.5 solved this issue.

I did on TransactionalEmailsApi but not on all other :( Do you plan a larger fix ? Thanks

remialvado avatar Jun 04 '25 09:06 remialvado