Fix Implicitly marking parameters TransactionalEmailsApi.php on php 8.4
On PHP 8.4 when we sent a transactional email, some deprecated messages are log
Message log detail : Deprecated: Brevo\Client\Api\TransactionalEmailsApi::__construct(): Implicitly marking parameter $client as nullable is deprecated, the explicit nullable type must be used instead in /var/www/app/vendor/getbrevo/brevo-php/lib/Api/TransactionalEmailsApi.php on line 72
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
62.5% Duplication on New Code
This pull request should be accepted in order to migrate to PHP 8.4
Thank you
how can we get this merged, please advise on the process - this is creating a lot of noise in our log files
This PR should fix https://github.com/getbrevo/brevo-php/issues/57.
But as stated by @LaurentBrieu in the above issue, this fix will break compatibility with PHP < 7.1 and as such, the minimum PHP version should be updated in composer.json and I guess this will require a major release.
Much needed indeed!
+1 !
+1
+1!
+1!
@sowmyahora2001 @nik-sib @preetishishodia7 would you please consider merging this, stop supporting PHP 5.6/7.0, and tag a new version? :pray:
I think commit https://github.com/getbrevo/brevo-php/commit/89b2fb859e56b79649ed10e5f7687b267ad4908c included in release v2.0.5 solved this issue.