AppBox-iOSAppsWirelessInstallation icon indicating copy to clipboard operation
AppBox-iOSAppsWirelessInstallation copied to clipboard

Framework should only contain Redacted API Keys, and not the functionality

Open kunalverma25 opened this issue 5 years ago • 4 comments

The MailGun, TinyURL etc functionality is also inside the framework, So developers cannot extend and/or change that functionality. Which kinda diminishes the whole purpose of open-sourcing. Personally I think, only the keys should be redacted and not the functionality, so if some dev wants to extend the functionality, they can do so easily.

kunalverma25 avatar Mar 28 '19 09:03 kunalverma25

Hi, that doesn't make any sense because anyone can access those keys and misuse them.

I only added very limited functionality in the private framework. Before this, all these things were open source but some user doesn't want to create the key for mailgun and branch.io app to run the AppBox from source code. So, that's why created that private framework.

I'm thinking a different way, I'll open source that private framework without any key. Where user can rebuild that framework with their own key.

vineetchoudhary avatar Mar 28 '19 09:03 vineetchoudhary

Yeah.. Maybe a different branch, without the keys?

kunalverma25 avatar Mar 28 '19 10:03 kunalverma25

@vineetchoudhary Any estimated when, you'll be able to add this? Basically a way to add own keys/config for Dropbox, MailGun, Tiny etc.. Btw.. Thanks for such an awesome project!

kunalverma25 avatar Mar 28 '19 12:03 kunalverma25

Hi, I can't promise. But I'll surely work on it. I already have a few things to plan for this.

After these, I'll work on this.

vineetchoudhary avatar Mar 29 '19 06:03 vineetchoudhary