eth-client

eth-client copied to clipboard

Internal import references to its own github repo make forking and making PRs difficult

1

the istanbul and quorum clients reference their own git repo (getamis/eth-client) so forking and making a PR is kind of challenging, since any PR has to be reverted to point...

nyetwurk

Can't use quorum.Dial

2

```go package main import ( "log" "github.com/getamis/eth-client/quorum" ) func main() { c, err := quorum.Dial("http://0.0.0.0:8545") if err != nil { log.Fatalln(err) } } ``` I get the following error ```...

sadysnaat

Why is this a separate repo, while go-ethereum has an [`ethclient`](https://github.com/ethereum/go-ethereum/tree/master/ethclient) package and Quorum [too](https://github.com/jpmorganchase/quorum/tree/master/ethclient)? If there are any changes between `client` here and `go-ethereum/ethclient`, to make a PR there,...

stevenroose

Are all the api methods implemented?

5

I just checked out the latest code and I was having a look into the client.go source file and I could not find any implementation for some of the functions...

joesan