lightning-browser-extension icon indicating copy to clipboard operation
lightning-browser-extension copied to clipboard
verified publisher icon getAlby

feat(connector): added further fields to getinfo

Open reneaaron opened this issue 3 years ago • 2 comments

Link this PR to an issue

#748

Type of change (Remove other not matching type)

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • [x] Go to https://webln.twentyuno.net/info with your Alby / LNDHub account

Checklist:

  • [x] My code follows the style guidelines of this project and performed a self-review of my own code
  • [x] New and existing tests pass locally with my changes
  • [x] I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

reneaaron avatar Mar 31 '22 20:03 reneaaron

What's the status here? 😬

escapedcat avatar Jul 08 '22 04:07 escapedcat

WebLN back then did not think about custodial setups and in fact WebLN probably did not think much about what that getInfo information is useful for. (Why return the color there?)

I did not return the pub key there because it is is the shared pubkey... and not the user's pubkey.

but let's merge it.

@reneaaron can you fix the merge conflict?

bumi avatar Jul 15 '22 21:07 bumi

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.

This build is brought to you by: null (who recently dropped 210 sats):

Checkout the Alby Lightning Mixtape: https://alby-mixtape.vercel.app - happy coding!

Want to sponsor the next build? send some sats to ⚡️[email protected] (don't forget to provide your name)

Don't forget: keep stacking sats!

github-actions[bot] avatar Aug 15 '22 18:08 github-actions[bot]