lightning-browser-extension icon indicating copy to clipboard operation
lightning-browser-extension copied to clipboard

feat: update extension settings layout

Open amitamrutiya opened this issue 11 months ago • 6 comments

Describe the changes you have made in this PR

I have implemented the recommended changes mentioned in the issue. In this PR I make sure that:

  • Page tile contains a description "Global settings that affect your experience on all connected wallets in - Alby Extension.". Space between title and descriptions should be 4px.
  • Section headers are text-xl/bold
  • All buttons and dropdowns should have fixed 256px width
  • Use Title case in all list item labels and buttons
  • Delete Nostr section
  • Delete legacy section

Link this PR to an issue [optional]

#2874

Fixes #2874

Type of change

  • fix: remove legacy section from extension setting screen
  • fix: use title case in extension setting screen
  • feat: add extension setting subtitle and general section title

Screenshots of the changes [optional]

image

Checklist

  • [X] Self-review of changed code
  • [X] Manual testing
  • [X] Added automated tests where applicable
  • [X] Update Docs & Guides
  • For UI-related changes
  • [X] Darkmode
  • [X] Responsive layout

amitamrutiya avatar Mar 07 '24 04:03 amitamrutiya

Hey @amitamrutiya2210 are you still working on this one?

stackingsaunter avatar Mar 21 '24 21:03 stackingsaunter

From my side, the work is done. So, this PR is ready for review.

amitamrutiya avatar Mar 22 '24 01:03 amitamrutiya

@amitamrutiya2210 I see thanks 🙏🙏

stackingsaunter avatar Mar 22 '24 10:03 stackingsaunter

Thanks for the pr! fixed some layout issues and styles and code conventions. @reneaaron let me know if want some additional changes!

TODO: update wallet settings this focus only on extension settings

pavanjoshi914 avatar Apr 23 '24 10:04 pavanjoshi914

Rest LGTM!

pavanjoshi914 avatar Apr 23 '24 10:04 pavanjoshi914

regarding outdated translations warnings. i don't think we shall remove it. it's just that strings were capitalised in English version

pavanjoshi914 avatar Apr 26 '24 09:04 pavanjoshi914

tAck

pavanjoshi914 avatar May 10 '24 09:05 pavanjoshi914