lightning-browser-extension icon indicating copy to clipboard operation
lightning-browser-extension copied to clipboard

feat: add screen reader labels for better accessibility

Open volfiros opened this issue 2 years ago • 3 comments

Describe the changes you have made in this PR

Adding screen reader labels to elements wherever necessary for better accessibility.

For both the menus (user and account menus) as the Menu component is being used tab keys cannot be used to traverse menu items so instead I have added a screen reader message at the beginning of menu so that the user is notified that he can only use the arrow keys to access menu items.

Link this PR to an issue [optional]

Fixes #2573

Type of change

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)

How has this been tested?

Tested manually using a screen reader.

Checklist

  • [x] Self-review of changed code
  • [x] Manual testing
  • For UI-related changes
  • [x] Darkmode
  • [x] Responsive layout

volfiros avatar Dec 23 '23 06:12 volfiros

@rolnz Please review this PR. Thanks!

volfiros avatar Dec 23 '23 06:12 volfiros

@rolnz Please review this PR. Thanks!

I have added some translation keys for some component screen reader labelling. I guess there is no need to run any script for newly added keys. If it is not the case please give some feedback for further translations changes.

volfiros avatar Dec 23 '23 06:12 volfiros

With all the changes since last year this is not mergeable now? @reneaaron

stackingsaunter avatar May 16 '24 15:05 stackingsaunter