lightning-browser-extension icon indicating copy to clipboard operation
lightning-browser-extension copied to clipboard

Published 20 hours ago • verified publisher icon getAlby

Updates to Extension Settings layout

Open stackingsaunter opened this issue 1 year ago • 8 comments

Part of #2871 epic, which full desired effect can be viewed in this Figma

CleanShot 2023-11-16 at 22 50 44@2x

Changes:

  • Page tile contains a description "Global settings that affect your experience on all connected wallets in - Alby Extension.". Space between title and descriptions should be 4px.

  • Section headers are text-xl/bold

  • All buttons and dropdowns should have fixed 256px width

  • Use Title case in all list item labels and buttons

  • Delete Nostr section

  • Delete legacy section

stackingsaunter avatar Nov 16 '23 14:11 stackingsaunter

@stackingsaunter I got it.

  • Delete Nostr section
  • Delete legacy section

Are we removing the whole section?( settings part )

AdarshRawat1 avatar Nov 21 '23 17:11 AdarshRawat1

@AdarshRawat1 yes, whole UI parts of the section.

stackingsaunter avatar Nov 24 '23 10:11 stackingsaunter

Hey @AdarshRawat1, are you still working on this issue? If not, then @stackingsaunter, I would like to try tackling this good first issue.

amitamrutiya avatar Mar 06 '24 12:03 amitamrutiya

This one totally slipped my mind. 🤧

@amitamrutiya2210 if you wish to start contributing to Alby, you can start with this good first issue.

AdarshRawat1 avatar Mar 06 '24 14:03 AdarshRawat1

Thanks @AdarshRawat1, for replying. I will work on this issue then.

amitamrutiya avatar Mar 06 '24 14:03 amitamrutiya

Hey @stackingsaunter,

I think some of your suggested changes have already been addressed or removed in the current codebase, such as:

  • The subtitle "Global settings that affect your experience on all connected wallets in - Alby Extension" is not present.
  • The heading for the General section is missing.
  • All buttons and dropdowns have a fixed width of 256px.
  • There is no "Nostr" section.

Here are the things I need to do:

  • Delete the legacy section.
  • Use Title Case in all list item labels and buttons as suggested in figma file.

Is there anything you want to suggest?

amitamrutiya avatar Mar 06 '24 16:03 amitamrutiya

I think there is some confusion.

  • The subtitle "Global settings that affect your experience on all connected wallets in - Alby Extension" is not present.

Is there anything you want to suggest?

You have to add the subtitle as it is not present currently.

Check the final design in this Figma file and make changes accordingly. ( The points listed in issue description are there to help you find the changes to be made i.e. the difference between current design and desired design.)

AdarshRawat1 avatar Mar 06 '24 17:03 AdarshRawat1

Okay, I overthought this issue. Now I understand it.

amitamrutiya avatar Mar 07 '24 03:03 amitamrutiya