lightning-browser-extension icon indicating copy to clipboard operation
lightning-browser-extension copied to clipboard

Published 20 hours ago • verified publisher icon getAlby

Swap "accounts" for "wallets" copy

Open stackingsaunter opened this issue 1 year ago • 10 comments

Part of #2871 epic, which full desired effect can be viewed in this Figma

Goal is to change copy related to "extension accounts" that from now on will be called "wallets".

List of changes:

Dropdowns

  • "Settings" --> "Extension Settings"
  • "Account settings" --> "Wallet Settings"
  • "Add an account" --> "Connect a Wallet"
  • "Manage accounts" --> "Manage Wallets
  • "Switch account" --> "Switch Wallet"

image

"Settings" page

  • Page title changes to "Extensions Settings"

"Account settings" page

  • Page title changes to "Wallet Settings"

"Accounts" (Manage accounts)

  • Title changes to "Wallets"
  • Button copy changes to "Connect a Wallet"

CleanShot 2023-11-16 at 21 18 42@2x

stackingsaunter avatar Nov 16 '23 13:11 stackingsaunter

@stackingsaunter Could you please provide path details of the files that need to be changed? It would be really helpful.

ayushdhiman-py avatar Nov 17 '23 19:11 ayushdhiman-py

@ayushdhiman-py this is part of the task to figure that out and make the changes.

rolznz avatar Nov 18 '23 06:11 rolznz

@stackingsaunter I went through the figma files and reviewed all the required changes, I will immediately start working on the issue once I finish setting it up.

Harshit-Prasad avatar Nov 18 '23 18:11 Harshit-Prasad

@stackingsaunter sorry but i won't be continuing the issue, thank you as I got to learn about react-i18n. Also this was my first time working on an extension.

Harshit-Prasad avatar Nov 19 '23 12:11 Harshit-Prasad

@Harshit-Prasad thanks for you work. I don't think the translations are an issue here and we can remove the outdated keys of the other languages by running a script.

rolznz avatar Nov 20 '23 07:11 rolznz

@rolznz I'll be taking on this issue.

AdarshRawat1 avatar Nov 21 '23 17:11 AdarshRawat1

@AdarshRawat1 forgot to mention this in initial post

On Wallet Settings page in "Danger" zone copy also must be updated to wallets:

CleanShot 2023-12-01 at 12 07 49@2x

stackingsaunter avatar Dec 01 '23 11:12 stackingsaunter

On Wallet Settings page in "Danger" zone copy also must be updated to wallets:

@stackingsaunter noted !!

AdarshRawat1 avatar Dec 01 '23 16:12 AdarshRawat1

@stackingsaunter, if this issue is still valid, I would like to work on it.

I noticed that in the wallet setting screen, we still use the account name in some places, such as:

  • "Danger Zone"
  • "Back up your master key description"

amitamrutiya avatar Mar 07 '24 13:03 amitamrutiya

@amitamrutiya2210 Good point, I just revisited the translations file and found 50 mentions of account. Feel free to revisit those occurrences and update them. (please don't just search & replace but go trough them as the context matters quite a bit)

reneaaron avatar Mar 08 '24 08:03 reneaaron