lightning-browser-extension icon indicating copy to clipboard operation
lightning-browser-extension copied to clipboard

feat: add the alby logo to the QR used for invoices

Open volfiros opened this issue 2 years ago • 2 comments

Describe the changes you have made in this PR

Added the Alby logo to the QR code used for invoices.

Link this PR to an issue [optional]

Fixes #2757

Type of change

  • feat: New feature (non-breaking change which adds functionality)

Screenshots of the changes [optional]

Tk60gUEYmV

How has this been tested?

Tested by creating an invoice.

Checklist

  • [x] Self-review of changed code
  • [x] Manual testing

volfiros avatar Oct 03 '23 03:10 volfiros

@rolznz Can you please review the changes. Thanks!

volfiros avatar Oct 03 '23 03:10 volfiros

@rolnz I have the made the change for using the avatar if it's an Alby user or else the logo would be used. I did not make any change to the static QR in the receive screen for now. Thanks!

volfiros avatar Oct 04 '23 06:10 volfiros

update this pr and tested it with breeze, phoenix, WOS, bluewallet,strike, normal camera scanner

pavanjoshi914 avatar Jul 11 '24 11:07 pavanjoshi914