lightning-browser-extension icon indicating copy to clipboard operation
lightning-browser-extension copied to clipboard

[BUG] Pay now button is enabled even with no balance sufficient

Open bitcoinuser opened this issue 2 years ago • 3 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Describe the bug

Hi,

If I click to buy with lightning on https://deezy.place/inscription/fda4cdd0770758dcae569e85612477f4646c7e21d339823dfc19a01d264ae9abi0 and my balance is less than the ordinal price, Alby still show the popup with no indication that I have a lower balance than the ordinal price, and the pay now button is enabled.

Screenshots [optional]

Captura de tela de 2023-10-01 16-15-21

Steps To Reproduce

1- Connect on https://deezy.place/ 2- Go to https://deezy.place/inscription/fda4cdd0770758dcae569e85612477f4646c7e21d339823dfc19a01d264ae9abi0 and click to buy with lightning (you need to have a balance on Alby less than the value of the ordinal)

Expected behavior

1- Show some message that my balance is less than the ordinal price. 2- The pay now button be disabled.

Alby information

Alby: 3.2.1

Device information

No response

Additional context

No response

Are you working on this?

No

bitcoinuser avatar Oct 01 '23 19:10 bitcoinuser

@rolznz I would like to work on this, can you assign me this issue. @stackingsaunter which one would be better to show a toast or add a new component in the popup to show the balance is insufficient. Thanks!

volfiros avatar Oct 01 '23 19:10 volfiros

When making the payment itself, it will also fail with an insufficient budget error message. I don't think it's that important? maybe we wait for @stackingsaunter 's feedback on UX first.

rolznz avatar Oct 02 '23 05:10 rolznz

Sorry for late reply @Rithvik-padma @bitcoinuser

I am working on a small redesign of payments approval/screens and will include this info in this, then create a separate issue to introduce all changes at once"

Also I added this request to our github: https://feedback.getalby.com/-request-a-feature/posts/indicate-there-s-not-enough-balance-when-approving-a-payment

If you login and upvote, you will get notified when it's introduced in the extension :)

stackingsaunter avatar Dec 02 '23 22:12 stackingsaunter