getAlby
[Feature] Add logo to the QR codes for invoices
Feature description
Adding the Alby logo to the QR code used for invoices
Describe the solution
Currently we are using the react-qr-code package for creating QR code with invoice instead we can use the react-qrcode-logo package to add a logo to the QR codes.
Describe alternatives
No response
Additional context
Are you working on this?
Yes
@Rithvik-padma I am not sure this is necessary now. We just merged a PR to add the user's account avatar to the QR code. Can you please checkout master and try it?
@Rithvik-padma I am not sure this is necessary now. We just merged a PR to add the user's account avatar to the QR code. Can you please checkout master and try it?
Ohh I was using a LND test account so I couldn't find that, but we can add the alby logo for non-alby users instead of the avatar (better than a plain QR code), only if it sounds necessary.
I think this can be nice-have if it won't affect scanning. I would use Alby head with white stroke here though so it's visable, or in a white circle. It would be great If you could match the design style here
Yes, I am working on it.
On Mon, 2 Oct, 2023, 12:48 PM Roland, @.***> wrote:
@Rithvik-padma https://github.com/Rithvik-padma did you work on this one?
— Reply to this email directly, view it on GitHub https://github.com/getAlby/lightning-browser-extension/issues/2757#issuecomment-1742511168, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4MOVRRL7ET5HYP76B4LQ2LX5JTC3ANCNFSM6AAAAAA44EWDLI . You are receiving this because you commented.Message ID: @.***>
@Rithvik-padma did you work on this one?
Yes I have made the changes locally, will make a PR soon. Thanks!
@stackingsaunter I feel the image you provided is too small considering the QR code size
this is icon you have provided but this is small and of size 32x32 ig.
this is of size 64x64 (expanded version)
should I use the icon you have provided or if not can you provide the icon I should use here. Thanks!
@Rithvik-padma can you use an svg version of the icon?
Yes, I am using a svg version only, okay so anyway it will not affect the quality. Thanks!