lightning-browser-extension icon indicating copy to clipboard operation
lightning-browser-extension copied to clipboard

add eslint rule to force absolute imports

Open rolznz opened this issue 1 year ago β€’ 5 comments

Feature description

Imports should be consistent and relative imports often break when moving files

Describe the solution

Add an eslint rule like:

"no-restricted-imports": [
      "error",
      {
        "patterns": [".*"]
      }
    ],

Additional aliases in tsconfig could be added to make the absolute imports shorter.

Describe alternatives

No response

Additional context

No response

Are you working on this?

None

rolznz avatar Jun 20 '23 09:06 rolznz

@rolznz I would like to work on this issue, can you assign it to me. Thanks!

Rithvik-padma avatar Sep 29 '23 23:09 Rithvik-padma

@reneaaron @bumi are you ok with going ahead to make this change?

rolznz avatar Sep 30 '23 03:09 rolznz

Hey @rolznz plz assign it to me, i would luv to work on itπŸ˜ƒπŸ˜„

AryanParashar24 avatar Oct 05 '23 16:10 AryanParashar24

Sorry, we still need approval from the Alby team for this issue.

rolznz avatar Oct 06 '23 03:10 rolznz

I never had real problems when moving files, but maybe I was just lucky. Would you update all files with this PR then @rolznz?

reneaaron avatar Oct 12 '23 14:10 reneaaron