lightning-browser-extension icon indicating copy to clipboard operation
lightning-browser-extension copied to clipboard

fix: fiat value 0 due to slow connection

Open vaibhavgarg237 opened this issue 2 years ago • 1 comments

Describe the changes you have made in this PR

During loading due to a slow connection, fiatBalance is shown ~$0, so "..." will be shown when the user has some satsBalance but due to a network issue, fiatBalance is not fetched properly.

Link this PR to an issue [optional]

Fixes #1608

Type of change

(Remove other not matching type)

  • fix: Bug fix (non-breaking change which fixes an issue)

How has this been tested?

As mentioned in the issue issue only reproduces due to slow connection, so I tested by hard coding values.

Checklist

  • [x] My code follows the style guidelines of this project and performed a self-review of my own code
  • [x] New and existing tests pass locally with my changes
  • [x] I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

vaibhavgarg237 avatar Oct 13 '22 17:10 vaibhavgarg237

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.


This build is brought to you by: Adam Fiscor (who recently dropped 1337 sats):

The future is bright. We just have a lot of work to do.

Want to sponsor the next build? send some sats to ⚡️[email protected] (don't forget to provide your name)

Don't forget: keep stacking sats!

github-actions[bot] avatar Oct 13 '22 17:10 github-actions[bot]

Closing this in favour of #1645
@vaibhavgarg237 thanks for starting this!

escapedcat avatar Oct 21 '22 06:10 escapedcat