lightning-browser-extension icon indicating copy to clipboard operation
lightning-browser-extension copied to clipboard

feat: start commando connector

Open kiwiidb opened this issue 2 years ago β€’ 1 comments

Draft PR to track #1390

Schermafbeelding 2022-10-06 om 22 28 22

kiwiidb avatar Oct 06 '22 20:10 kiwiidb

πŸš€ Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.


This build is brought to you by: Adam Fiscor (who recently dropped 1337 sats):

The future is bright. We just have a lot of work to do.

Want to sponsor the next build? send some sats to ⚑️[email protected] (don't forget to provide your name)

Don't forget: keep earning sats!

github-actions[bot] avatar Oct 06 '22 20:10 github-actions[bot]

Socket Security Pull Request Report

πŸ‘ No new dependency issues detected in pull request

Pull request report summary
Issue Status
Install scripts βœ… 0 issues
Native code βœ… 0 issues
Bin script confusion βœ… 0 issues
Bin script shell injection βœ… 0 issues
Unresolved require βœ… 0 issues
Invalid package.json βœ… 0 issues
HTTP dependency βœ… 0 issues
Git dependency βœ… 0 issues
Potential typo squat βœ… 0 issues
Known Malware βœ… 0 issues
Telemetry βœ… 0 issues
Protestware/Troll package βœ… 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] [email protected]

⚠️ Please accept the latest app permissions to ensure bot commands work properly. Accept the new permissions here.

Powered by socket.dev

socket-security[bot] avatar Oct 24 '22 07:10 socket-security[bot]

bumi noticed: package-lock.json can be removed. We use yarn and yarn.lock.

escapedcat avatar Oct 24 '22 09:10 escapedcat

Boostagrams are currently not supported. As pointed out by Aaron over e-mail:

Actually it looks like the extratlvs​ field was only merged in to master on the 22nd of September - https://github.com/ElementsProject/lightning/pull/5619

I just checked with the CoreLn team and they said that it is going in to the next release.

So you can test it by installing CoreLn from master rather than a tagged release for the moment.

Aaron

So if we want to test this, we have to wait for the next Core LN release or build from master.

kiwiidb avatar Oct 25 '22 06:10 kiwiidb

Updated with fixes for some of @bumi 's remark. I don't know anything about the webpack/storyboard stuff though.

kiwiidb avatar Oct 26 '22 08:10 kiwiidb