lightning-browser-extension icon indicating copy to clipboard operation
lightning-browser-extension copied to clipboard

back and forth navigation on the publisher screen

Open MoritzKa opened this issue 2 years ago • 17 comments

Feature description

The latest release allows navigating to the home screen in the pop up. But there is no way to navigate back to the website/publisher screen

Describe the solution

Add the possibility to navigate back and forth just for illustration purposes image image

Additional context [optional]

Add any other additional context or screenshots about the feature request here

Are you working on this?

(Yes/No)

MoritzKa avatar Oct 05 '22 11:10 MoritzKa

not urgent.

MoritzKa avatar Oct 05 '22 11:10 MoritzKa

I think this has been there for a while already and not part of the latest release. is this really a case? why did you want to do that?

(closing and opening the popup does that)

bumi avatar Oct 05 '22 12:10 bumi

I would like to work on the issue can you assign this to me.

ranjithjupaka avatar Oct 14 '22 06:10 ranjithjupaka

I would like to work on the issue can you assign this to me.

Before any action maybe describe how you would tackle this first. Would like to avoid you wasting time.
I think we still need at least a mockup and/or a design as well.

escapedcat avatar Oct 14 '22 13:10 escapedcat

Hello @bumi @escapedcat, I am Dinesh I wanted to contribute to this task can you guide me through this as I'm new to it and I am A SOB participant.

iamdiinesh avatar Mar 10 '23 04:03 iamdiinesh

Not sure what the priority is here. Maybe @stackingsaunter has some input/feedback.

escapedcat avatar Mar 10 '23 14:03 escapedcat

Hello @stackingsaunter I wanted to contribute to the task can you guide me through this as I'm new to it and I am A SOB participant.

iamdiinesh avatar Mar 13 '23 08:03 iamdiinesh

@MoritzKa What would you say if instead of showing website and it's history, we could show main balance with some "connected" card that could allow you to view history?

This also solves the problem that on website view we dont have send/receive buttons

CleanShot 2024-01-29 at 16 19 11@2x

stackingsaunter avatar Jan 29 '24 15:01 stackingsaunter

Sounds good. Makes sense for me.

MoritzKa avatar Jan 29 '24 16:01 MoritzKa

Hi @MoritzKa, is this issue ready to be implemented or are we waiting for confirmation? If the design is finalized as @stackingsaunter suggested, I would like to work on this issue.

CleanShot 2024-01-29 at 16 19 11@2x

amitamrutiya avatar Mar 08 '24 06:03 amitamrutiya

from my side yes. @stackingsaunter what do you think?

MoritzKa avatar Mar 08 '24 09:03 MoritzKa

@stackingsaunter How is that supposed to for tipping information provided by websites? (e.g. twitter profiles, etc)

image

reneaaron avatar Mar 08 '24 10:03 reneaaron

@amitamrutiya2210 I need to finalise the design and address what @reneaaron is asking. After that you could pick it up!

stackingsaunter avatar Mar 13 '24 10:03 stackingsaunter

@reneaaron so this stays the same. There shouldn't be any interference, right? I'd just add more breather to both sections:

image

Handoff is prepared in Figma with spacing laid out.

Except layout, I did 2 minor changes:

  • settings icon changed to popicons and is inside a button in subheader
  • Budget label changes from text-base/medium to text-sm/medium

@reneaaron can you review and If it's good you can assign @amitamrutiya2210 to the issue?

stackingsaunter avatar Mar 15 '24 16:03 stackingsaunter

I think there still is. Suppose you have a website like webln.twentyuno.net which is using the meta tag (triggering the publisher widget) + using WebLN (triggering the allowance). Would you then just show both sections beneath each other?

reneaaron avatar Mar 19 '24 10:03 reneaaron

image

Then it could work like this.

@amitamrutiya2210 would you like to implement above?

stackingsaunter avatar Mar 19 '24 14:03 stackingsaunter

I have some work in this week so from next week I will start to work on this issue.

amitamrutiya avatar Mar 19 '24 15:03 amitamrutiya