lightning-browser-extension icon indicating copy to clipboard operation
lightning-browser-extension copied to clipboard

Published 20 hours ago • verified publisher icon getAlby

Send screen from popup should not show "Remember and set a budget" when i.e. pasting a lightning invoice (or other screens)

Open bitcoinuser opened this issue 2 years ago • 5 comments

Describe the bug

If I create a ln invoice on a wallet like Phoenix and copy it and paste on Alby, Alby show the option Remember and set a budget. But doesn't make sense, because it's not a service or a page, so it's not saved.

Screenshots

Captura de tela de 2022-09-23 10-59-01

To Reproduce

Steps to reproduce the behavior:

  1. Generate a ln invoice on a ln wallet like Phoenix and copy the invoice.
  2. Click on Alby send button, then paste the invoice and click continue button

Expected behavior

Remember and set a budget option not be showed.

Alby information

  • Alby Version: 1.15.1

bitcoinuser avatar Sep 23 '22 14:09 bitcoinuser

I'm working on this

vaibhavgarg237 avatar Sep 25 '22 19:09 vaibhavgarg237

I'm working on this

Thanks! Let me know if you get stuck or need more info

escapedcat avatar Sep 26 '22 02:09 escapedcat

Heyhey @vaibhavgarg237 , did you already start with this? Do you need any support?

escapedcat avatar Sep 28 '22 07:09 escapedcat

Heyhey @vaibhavgarg237 , did you already start with this? Do you need any support?

It's almost complete, I got occupied in some office work... Although I was facing some issues related to running tests locally. So I was thinking to first run locally and then do the PR. Will create the draft PR today...

vaibhavgarg237 avatar Sep 28 '22 07:09 vaibhavgarg237

Will create the draft PR today

Perfect, yes! No worries if it's not "ready ready" yet. Just seeing some progress is already helpful. Thanks for your quick reply!

escapedcat avatar Sep 28 '22 08:09 escapedcat