lightning-browser-extension icon indicating copy to clipboard operation
lightning-browser-extension copied to clipboard

Update node version to 18 to stay up-to-date

Open escapedcat opened this issue 3 years ago • 0 comments

Is your feature request related to a problem?

We're currently using v14 which is maintenance is running out April next year. See: https://nodejs.org/en/about/releases/

Describe the solution you'd like

  • Update node version to latest v18 in i.e.
    • node-version
    • .nvmrc
  • Install it
  • Test if dev task still work
  • Test if build still works

Additional context

Unit-test setup

Looks like some unit-tests fail after an update to 16/18. This helps partly:

  • Updating runcitadel #1280
  • transformIgnorePatterns: ["node_modules/(?!(dexie))/"],
  • Update jest (and related)to v29
  • In other cases more mocking helps, i.e.:
    jest.mock("~/common/lib/utils");
    jest.mock("~/common/utils/currencyConvert");
    

Failing npm deps

  • https://github.com/getAlby/lightning-browser-extension/pull/1549 Latest wext-manifest-loader needs node v16.15.0 as a minimum
    Update will be paused via depfu for now

escapedcat avatar Aug 21 '22 02:08 escapedcat