lightning-browser-extension icon indicating copy to clipboard operation
lightning-browser-extension copied to clipboard
verified publisher icon getAlby

fix(lnurlpay): correct close for popup/prompt

Open escapedcat opened this issue 3 years ago • 4 comments

Describe the changes you have made in this PR

This should fix the close action for the success view

Link this PR to an issue

#1216

Type of change (Remove other not matching type)

  • fix: Bug fix (non-breaking change which fixes an issue)

How has this been tested?

image

Looks like fiatjef doesn't have enough inbound liquidity?
How to test this nicely?

Checklist

  • [ ] My code follows the style guidelines of this project and performed a self-review of my own code
  • [ ] New and existing tests pass locally with my changes
  • [ ] I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

escapedcat avatar Aug 12 '22 09:08 escapedcat

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.

This build is brought to you by: null (who recently dropped 21 sats):

nodesignal.space ist der beste Bitcoin podcast!

Want to sponsor the next build? send some sats to ⚡️[email protected] (don't forget to provide your name)

Don't forget: keep stacking sats!

github-actions[bot] avatar Aug 12 '22 09:08 github-actions[bot]

the success view in which context?

the prompt must reply that the response is sent back to the webln.lnurl call for example.

bumi avatar Aug 12 '22 09:08 bumi

the success view in which context? the prompt must reply that the response is sent back to the webln.lnurl call for example.

Ah ok, hm, need to test this. Will switch the PR to draft.

escapedcat avatar Aug 12 '22 09:08 escapedcat

is this mergeable

bumi avatar Aug 15 '22 09:08 bumi

what's up with this one?

bumi avatar Aug 23 '22 08:08 bumi