lightning-browser-extension icon indicating copy to clipboard operation
lightning-browser-extension copied to clipboard

refactor: update copy, add link and remove unfinished language selector

Open secondl1ght opened this issue 3 years ago • 8 comments

Describe the changes you have made in this PR

Updated copy for language selector in Settings based on user feedback, also added a link to the Weblate for translations, and removed unfinished languages to avoid further confusion.

Link this PR to an issue

#1192

Type of change (Remove other not matching type)

  • fix: Bug fix (non-breaking change which fixes an issue)

Screenshots of the changes (If any)

image

How has this been tested?

Ran locally

Checklist

  • [x] My code follows the style guidelines of this project and performed a self-review of my own code
  • [x] New and existing tests pass locally with my changes
  • [x] I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

secondl1ght avatar Aug 05 '22 22:08 secondl1ght

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.


This build is brought to you by: null (who recently dropped 210 sats):

Checkout the Alby Lightning Mixtape: https://alby-mixtape.vercel.app - happy coding!

Want to sponsor the next build? send some sats to ⚡️[email protected] (don't forget to provide your name)

Don't forget: keep stacking sats!

github-actions[bot] avatar Aug 05 '22 22:08 github-actions[bot]

Would this work to avoid an extra link-prop?: https://stackoverflow.com/a/70769183/1667461

escapedcat avatar Aug 06 '22 06:08 escapedcat

Would this work to avoid an extra link-prop?: https://stackoverflow.com/a/70769183/1667461

Can you pass a React component in as a component prop though, I thought you could not? I can try and see.

secondl1ght avatar Aug 06 '22 06:08 secondl1ght

Refactored to remove the new prop and use the Trans component.

secondl1ght avatar Aug 11 '22 16:08 secondl1ght

I am kinda lost here. what is this Trans doing exactly? and do we really need that link?

bumi avatar Aug 14 '22 09:08 bumi

I am kinda lost here. what is this Trans doing exactly?

Trans helps us to handle html-tags within translations strings. We already use it in other places.
Getting familiar with its usage will help with all further situations where we have to deal with html-tags.

and do we really need that link?

I believe it's a good starting point for people who might be interested in adding languages.

escapedcat avatar Aug 14 '22 10:08 escapedcat

ok, then can this be merged?

bumi avatar Aug 15 '22 09:08 bumi

ok, then can this be merged?

No, we should get rid of the extra link-prop

escapedcat avatar Aug 15 '22 09:08 escapedcat