getAlby
Changing the language does not work
Bug description
In the settings there is an option to change language, but it doesn't work
Screenshots
Steps to reproduce the behaviour:
- Click on Alby Extension Icon
- Pop up window appears
- Click on the "menu" button in the right
- The menu appears
- Click on "settings"
- "Settings" page appears
- In the line "Language" try to change it
Expected behavior
The language changes to the chosen one
Suggestion
Either remove the option for changing or make it work
Alby information
Alby Version: [v1.12.0] Alby installed through Google Chrome
Device information:
OS: [macOS Monterey 12.0.1 ] Browser [chrome] Browser Version [Chrome Version 103.0.5060.114]
Are you working on this issue?
No
Not all languages have been translated completely yet. This will happen over time via Weblate. I think this can be closed.
Maybe it makes sense to remove this option before it's done? It gives the impression of a very raw product
True, I understand that. Doubt translations will be 100% finished soon. We kinda wanted this in so people are aware of it.
Maybe we could improve the info here:
- Change to "Translations are not 100% finished yet. Help us translate Alby into your language!
- "translate Alby into your language" link this to the Weblate service we use for translations
Yes, then it turns out to be even useful! love it!
P.S. I think translations are very important, actually. For example, most Russians don't speak English at all. Neither do Spaniards. It might even stop them from using the product.
I agree that the current setup is not correct, we should only show a language in the selector when the entire app has been translated. It doesn't make sense to show it otherwise, so we could only show English for now and then when we have full translations add the other languages.
For the entire app to be translatable we need to switch all strings to i18n placeholders first. You up for it?
PR #1244 is in for this issue, will now look into updating remaining strings into i18n placeholders.