lightning-browser-extension icon indicating copy to clipboard operation
lightning-browser-extension copied to clipboard
verified publisher icon getAlby

feat: add feedback form on uninstall

Open secondl1ght opened this issue 3 years ago • 8 comments

Describe the changes you have made in this PR

When a user uninstalls Alby they will now be directed to this URL: https://form.jotform.com/221745756722057

Link this PR to an issue

#210

Type of change (Remove other not matching type)

  • feat: New feature (non-breaking change which adds functionality)

Screenshots of the changes (If any)

image

How has this been tested?

Uninstalled the app and was taken to the feedback form.

Checklist

  • [x] My code follows the style guidelines of this project and performed a self-review of my own code
  • [x] New and existing tests pass locally with my changes
  • [x] I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

secondl1ght avatar Jul 20 '22 03:07 secondl1ght

tested successfully on Chrome. There is also a "remove from Chrome" button in the Chrome app store. I assume it triggers the same behaviour.

image

MoritzKa avatar Jul 20 '22 06:07 MoritzKa

This PR needs to be merged at the same time: https://github.com/getAlby/website/pull/141

NOTE: The above PR has been closed and a new one will be opened in the Rails app.

secondl1ght avatar Jul 20 '22 16:07 secondl1ght

Converted to draft till the blocking PR is ready.

escapedcat avatar Jul 21 '22 02:07 escapedcat

This PR is ready to be merged when this one gets merged: https://github.com/getAlby/getalby.com/pull/182

secondl1ght avatar Jul 21 '22 04:07 secondl1ght

💁‍♂️ https://github.com/getAlby/getalby.com/pull/182 has been merged

escapedcat avatar Aug 03 '22 05:08 escapedcat

tipping_hand_man getAlby/getalby.com#182 has been merged

Can we merge this then?

secondl1ght avatar Aug 05 '22 22:08 secondl1ght

Let's merge it @bumi
Just wondering why uninstall leads to /thanks :D

escapedcat avatar Aug 06 '22 04:08 escapedcat

Let's merge it @bumi Just wondering why uninstall leads to /thanks :D

Haha I thought it would be nice for them to leave on a good note like 'thanks for trying out Alby, we hope you come back!'. :P

secondl1ght avatar Aug 06 '22 04:08 secondl1ght

builds were outdated and I cannot create new ones. If tested it some weeks ago and wanted to look into that

uninstall leads to /thanks

uninstall should no lead to /thanks . We should thank users if they leave feedback.

MoritzKa avatar Aug 20 '22 15:08 MoritzKa

@escapedcat suggests /goodbye . That´s a good suggestion.

@secondl1ght can you adjust that on getalby.com/... ?

MoritzKa avatar Aug 22 '22 12:08 MoritzKa

@escapedcat suggests /goodbye . That´s a good suggestion.

@secondl1ght can you adjust that on getalby.com/... ?

Ok this is updated now.

secondl1ght avatar Aug 22 '22 14:08 secondl1ght

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.

This build is brought to you by: null (who recently dropped 21 sats):

nodesignal.space ist der beste Bitcoin podcast!

Want to sponsor the next build? send some sats to ⚡️[email protected] (don't forget to provide your name)

Don't forget: keep stacking sats!

github-actions[bot] avatar Aug 22 '22 14:08 github-actions[bot]

@secondl1ght do we need to update this as well or you already did?: https://github.com/getAlby/website/pull/141

escapedcat avatar Aug 23 '22 01:08 escapedcat

@secondl1ght do we need to update this as well or you already did?: getAlby/website#141

Already updated it on the Rails repo here: https://github.com/getAlby/getalby.com/commit/8583e2981787ebaebf6394ef2bc33524a30938bb

So this is ready to be merged 🚀

secondl1ght avatar Aug 23 '22 02:08 secondl1ght