js-sdk icon indicating copy to clipboard operation
js-sdk copied to clipboard

Refactor: Modularize the code

Open guptamukund22 opened this issue 9 months ago • 3 comments

  • Refactored API client to introduce modular HTTP handlers (httpGet, httpPost, httpDelete) for improved code readability, maintainability, and reduced redundancy across API endpoint methods.

guptamukund22 avatar Apr 01 '25 09:04 guptamukund22

most of the changes look irrelevant here. https://github.com/getAlby/js-sdk/blob/master/.vscode/settings.json we use prettier for formatting and enforce traillingComma rule on code formats. and i guess you just removed at most of the place. can you update this pr to undo this?

pavanjoshi914 avatar Apr 02 '25 12:04 pavanjoshi914

I have fixed the formatting issues using prettier. Please let me know if any other changes are needed.

guptamukund22 avatar Apr 02 '25 14:04 guptamukund22

Hi @guptamukund22 could you fix the conflict? and @pavanjoshi914 could you do a more thorough review?

rolznz avatar Apr 14 '25 13:04 rolznz