10101 icon indicating copy to clipboard operation
10101 copied to clipboard

Align `check_version` with SemVer rules

Open luckysori opened this issue 3 months ago • 0 comments

Atm we treat version number that have the same major version but a different minor version as incompatible:

https://github.com/get10101/10101/blob/d42a8c94003a2bdf62d7b3514ee6a5341c0faf6f/coordinator/src/check_version.rs#L77-L83

This is not what SemVer recommends:

Given a version number MAJOR.MINOR.PATCH, increment the:

  1. MAJOR version when you make incompatible API changes
  2. MINOR version when you add functionality in a backward compatible manner
  3. PATCH version when you make backward compatible bug fixes

We want to change this to avoid confusion.

To release this change safely we should bump the major version.

luckysori avatar May 10 '24 00:05 luckysori