rio icon indicating copy to clipboard operation
rio copied to clipboard

Enhancement: try_import()

Open bokov opened this issue 4 years ago • 2 comments

I'm not super keen on trying to parse with every imaginable import function. That might produce some kind of unanticipated weird behavior if one of those underlying functions changes to start supporting different kind of file or if we add future functionality that changes the deterministic order of import attempts.

We could add a separate function that does that, though, like try_import().

Originally posted by @leeper in https://github.com/leeper/rio/issues/180#issuecomment-538634953

bokov avatar Oct 07 '19 21:10 bokov

Thanks!!!

R is up to 10,000 packages, WOW

On Mon, Oct 7, 2019 at 5:09 PM Alex F. Bokov, Ph.D. < [email protected]> wrote:

I'm not super keen on trying to parse with every imaginable import function. That might produce some kind of unanticipated weird behavior if one of those underlying functions changes to start supporting different kind of file or if we add future functionality that changes the deterministic order of import attempts.

We could add a separate function that does that, though, like try_import() .

Originally posted by @leeper https://github.com/leeper in #180 (comment) https://github.com/leeper/rio/issues/180#issuecomment-538634953

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/leeper/rio/issues/238?email_source=notifications&email_token=ADDTJBKMC7QHSHJEZW33SG3QNOQQZA5CNFSM4I6J2QCKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HQFXUHA, or mute the thread https://github.com/notifications/unsubscribe-auth/ADDTJBPJHFAV5GEPA2DCRV3QNOQQZANCNFSM4I6J2QCA .

rogerjdeangelis avatar Oct 08 '19 01:10 rogerjdeangelis

Working my way toward try_import(), first I'm submitting PRs for additional helper functions like isfiletext() in #239. Those will permit try_import() to be smarter about which import functions are tried and the order in which they are tried.

bokov avatar Oct 08 '19 20:10 bokov