adaR

adaR copied to clipboard

Doesn't compile on Ubuntu 18.04

4

Hi, when compiling on Ubuntu (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0) I unfortunately get ` In file included from ada/ada.cpp:3:0, from adaR.h:5, from adaR.cpp:1: ada/ada.h:5067:10: fatal error: charconv: No such file or directory...

cbpuschmann

`data_raw` has the relevant scripts

schochastics

schochastics

Further C++ improvement

4

yeah. I am eyeing on removing all of these https://github.com/schochastics/adaR/blob/14692c751ac2fdbc97caa5b491357788d51eb7f6/R/parse.R#L20-L42 _Originally posted by @chainsawriot in https://github.com/schochastics/adaR/issues/47#issuecomment-1737993665_

chainsawriot

parsing fails when protocol is missing

6

``` r adaR::ada_url_parse("bit.ly/32G1ciy") #> href protocol username password host hostname port pathname search #> 1 bit.ly/32G1ciy #> hash #> 1 urltools::url_parse("bit.ly/32G1ciy") #> scheme domain port path parameter fragment #> 1...

schochastics

public_suffix() doesnt work with paths

3

```r adaR::public_suffix("http://google.de/test") #> [1] NA ``` related to #51 Note that [psl](https://github.com/hrbrmstr/psl) also fails. ```r psl::public_suffix("http://google.de/test") #> [1] "de/test" ``` need to reconsider if this is a bug or a...

schochastics

speedup

8

runtime is ok, but given how fast ada-url is by itself, there is room to improvement at a) the interface R/C++ and b)the URLencoding to fix UTF8 support (see #1)

schochastics