Gerry Tan
Gerry Tan
(Internal Microsoft review) This PR looks good to me, nice work! Teamcity build link: https://hashicorp.teamcity.com/buildConfiguration/TF_AzureRM_AZURERM_SERVICE_PUBLIC_MACHINELEARNING/398381?buildTab=tests
Nice, the change looks good to me
Thank you for reporting @franzoni-daniele . I have confirmed compression is supported in the SDK: [model_jsondatasettypeproperties.go](https://github.com/hashicorp/go-azure-sdk/blob/main/resource-manager/datafactory/2018-06-01/datasets/model_jsondatasettypeproperties.go). We'll raise a PR for this. Meanwhile you can either use azapi or [data_factory_custom_dataset](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/data_factory_custom_dataset)....
Thank you for reviewing @katbyte , all comments have been addressed. Have also merged latest main and checked the GH workflow passes.
Thank you @catriona-m , I have addressed all the feedbacks. Also have merged latest main and rerun the linter test. Can you please have another look 🙏.
@catriona-m this PR is ready for you to take another look. I have addressed all feedbacks, merged latest main and fixed linter errors.
Thank you @catriona-m !
Sorry @jonathan-fileread I'm not familiar yet with this feature. However I would first figure out what API corresponds to that feature and cross check if it is supported in azuread....
Also please rerun acctest against latest commit hash, with typos on the test prefix variable fixed.
@sreallymatt I have addressed all your feedbacks, and acctest has been run against latest commit (see description). Please have another look.