graftM icon indicating copy to clipboard operation
graftM copied to clipboard

Published 20 hours ago • verified publisher icon geronimp

Geronimp jplace improvements

Open geronimp opened this issue 9 years ago • 3 comments

Hey here is the .jplace file patch.

It is synced with the slash error branch so please have a look at that one first (https://github.com/geronimp/graftM/pull/171) just so you're aware of all changes that are within this branch.

Thanks, Joel

geronimp avatar Jan 19 '16 23:01 geronimp

Instance variable check has been added.

geronimp avatar Jan 31 '16 04:01 geronimp

Sorry to be a bit narky, but in future would you mind please keeping fixes for different bugs in different branches? Reviewing fixes for multiple different bugs all in follow-on pull requests makes it difficult to understand your intent when reading the code. If they are in different branches we can merge fixes in the order that they pass review, rather than in the order that they are proposed. I won't bother reviewing this for now then. Thanks.

wwood avatar Jan 31 '16 05:01 wwood

That was my bad, apologies.

geronimp avatar Feb 01 '16 02:02 geronimp