apidemic icon indicating copy to clipboard operation
apidemic copied to clipboard

Published 20 hours ago • verified publisher icon gernest

0.5 - Feature scan endpoint directory

Open peteraba opened this issue 6 years ago • 9 comments

https://github.com/gernest/apidemic/issues/3

PR https://github.com/gernest/apidemic/pull/8 recreated.

peteraba avatar Apr 10 '18 09:04 peteraba

@gernest please check my responses before I fix the remaining issues.

peteraba avatar Apr 10 '18 11:04 peteraba

@gernest please check my changes.

peteraba avatar Apr 10 '18 20:04 peteraba

@gernest any chance you could check this?

peteraba avatar Apr 12 '18 11:04 peteraba

Hey sorry. I am checking it right now.

gernest avatar Apr 12 '18 12:04 gernest

@gernest I fixed the issues you pointed out in the code change.

I did not add tests for the addEndpoints function as there's currently none for the main package. If you really want to see those added, please give me some pointers on what exactly should be tested.

peteraba avatar Apr 12 '18 22:04 peteraba

@gernest would be cool to have these PRs closed as soon as possible. I won't be opening more anytime soon I think :wink:

peteraba avatar Apr 15 '18 14:04 peteraba

@gernest ?

peteraba avatar Apr 17 '18 09:04 peteraba

@peteraba I'm sorry. I am very sick right now. I will take another look the moment I recover and feel better.

gernest avatar Apr 17 '18 09:04 gernest

@gernest understood, get well soon!

peteraba avatar Apr 17 '18 09:04 peteraba