minimp3-rs icon indicating copy to clipboard operation
minimp3-rs copied to clipboard

minimp3 causes iOS app store rejection due to slice_deque use

Open alice-i-cecile opened this issue 3 years ago • 4 comments

Heads up, using the mp3 Bevy feature will cause your iOS app to get rejected because minimp3 depends on slice_deque which uses an internal API for memory allocation.

First reported in bevyengine/bevy#3145. minimp3-rs is a doubly-transitive dependency of ours.

The dependency that you're using here seems to be unmaintained, so migrating away is likely the only real solution.

alice-i-cecile avatar Nov 18 '21 21:11 alice-i-cecile

This is more or less a duplicate of https://github.com/germangb/minimp3-rs/issues/29

LiquidityC avatar Nov 18 '21 21:11 LiquidityC

I don't think these are exactly the same issues. My app is getting rejected because we are referencing the non-public symbols: _mach_vm_allocate, _mach_vm_deallocate, _mach_vm_remap .

These are still being referenced in the slice_ring_buffer fork, so I think this is a different issue from the security issue fixed by your fork.

ArthurKValladares avatar Jan 14 '22 01:01 ArthurKValladares

Oh. Perhaps that is the case. Can you provide a more detailed error and perhaps drop me an issue and I'll check if it's something I can fix.

LiquidityC avatar Jan 15 '22 07:01 LiquidityC

I very weirdly opened a PR for in your fork of this repo (I don't know what I was thinking either) that fixes and explains the issue a bit better: https://github.com/LiquidityC/minimp3-rs/pull/1

ArthurKValladares avatar Jan 15 '22 08:01 ArthurKValladares