Gerardo Pacheco

Results 77 comments of Gerardo Pacheco

FYI some CI checks will fail until this PR https://github.com/WordPress/gutenberg/pull/46220 gets merged.

Hey @SiobhyB 👋 I was wondering if you could review this PR? It just updates the React Native Reanimated library which includes a commit we [cherry-picked](https://github.com/wordpress-mobile/react-native-reanimated/pull/23) to support Jest 28+,...

> @geriux would it be possible to update the fork? Currently the fork is based on upstream version 2.9.1 (Jul 2022), the Jest helper issue (expect.extend) has been fixed in...

> That would be awesome. The issue is that Jest's `expect` package used to be CommonJS, and `require('extend')` used to return the actual `extend` object, but now it's an ESM...

Hey @jsnajdr 👋 I'm working on a [draft PR](https://github.com/WordPress/gutenberg/pull/47574) that will update the Reanimated version. In the meantime, you could try pointing to [this version](https://github.com/WordPress/gutenberg/pull/47574/files#diff-1f256578dd9ab8dda6c3913a55a588312129f3404bb0cdf0b1ab52f0a6937119R69) and see if this issue...

Hey there 👋 The Reanimated update is now merged in `trunk`.

> Turns out we need to cherry-pick one more patch for `react-native-reanimated`. There is the `react-native-reanimated/lib/index.js` file that contains an "export namespace as default" statement: Hey there @jsnajdr 👋 sorry...

> I would be still nice to have, as newer upstream versions have that patch. I see, we'll plan to bring that then into a patch release of our fork...

> @WordPress/native-mobile Hi, I need help solving the failing mobile unit tests and with any necessary changes to the block's native.js file. Hey there! I will check it out 👍

Hey @carolinan 👋 I created https://github.com/WordPress/gutenberg/pull/47967 that targets your branch. If CI checks we can merge it into your branch. Could you approve the PR if the changes look good...