oc-backend-plus icon indicating copy to clipboard operation
oc-backend-plus copied to clipboard
verified publisher icon gergo85

bug in "unused database settings" !

Open plyusninva opened this issue 7 years ago • 5 comments

According to the condition in the line below, the "slick_slider_settings" setting in the database will be deleted, because the files in this plugin are stored in the "/plugins/peterhegman/slickslider/" folder, and not in the "/plugins/slick/slider/" as checked by you. https://github.com/gergo85/oc-backend-plus/blob/1d3118fb288f8dbf4c58c56f01cf91edcb58e3d2/controllers/Trash.php#L39

Here is the link to the plugin https://octobercms.com/plugin/peterhegman-slickslider (https://github.com/phegman/October-CMS-Slick-Slider)

plyusninva avatar Aug 15 '18 10:08 plyusninva

Thank you for report this bug! I will fix it.

gergo85 avatar Aug 16 '18 07:08 gergo85

I fixed this issue. Please update the plugin!

gergo85 avatar Aug 22 '18 07:08 gergo85

this does not solve the problem, there are hundreds of such plugins.

plyusninva avatar Aug 23 '18 04:08 plyusninva

I will find a better solution.

gergo85 avatar Aug 28 '18 08:08 gergo85

I checked a lot of popular plugins. The most of them use the correct settings code, so I just added more exceptions for database search feature for now.

gergo85 avatar Oct 08 '18 07:10 gergo85