friendly-errors-webpack-plugin icon indicating copy to clipboard operation
friendly-errors-webpack-plugin copied to clipboard

feat: compatible with eslint-webpack-plugin

Open fangbinwei opened this issue 4 years ago • 5 comments

  1. compatible with eslint-webpack-plugin. it seems the plugin groups eslint-loader's errors as Module Error before. So now grouping eslint-webpack-plugin's error as transformers/esLintError.js at least.

eslint-loader will emit multi-errors according to the number of files with errors. eslint-webpack-plugin will gather and throw only one compilation.errors/warnings. It is caused by the difference between loader and plugin in some degree.

  1. change 1 errors to 1 error

when using eslint-loader: image

When using eslint-webpack-plugin before this pr: image

When using eslint-webpack-plugin after this pr: :

image

fangbinwei avatar Nov 22 '20 10:11 fangbinwei

Is there any update on this PR? It would be nice to have support for eslint-webpack-plugin.

coreyleelarson avatar Dec 21 '20 21:12 coreyleelarson

I've shipped this feature in my fork of this plugin: https://github.com/sodatea/friendly-errors-webpack-plugin/releases/tag/v1.8.0

haoqunjiang avatar Jan 04 '21 04:01 haoqunjiang

I've shipped this feature in my fork of this plugin: https://github.com/sodatea/friendly-errors-webpack-plugin/releases/tag/v1.8.0

That's great! There are also a few features and necessary bugfixes in the next/2.0.0-beta.2 version that have been sitting in a beta release for a little over a year you might not want to miss.

coreyleelarson avatar Jan 04 '21 19:01 coreyleelarson

image

I noticed there seem to be [some]* cases where certain rules emit an error that isn't parsed properly. Not exclusive to this branch- but another incompatibility between friendly-errors and the new eslint plugin.

*I think there are several but at least no-unused-vars

binury avatar Mar 23 '21 19:03 binury

I have no idea, could you provide reproduction repo? @binury

fangbinwei avatar Mar 24 '21 11:03 fangbinwei