gInk icon indicating copy to clipboard operation
gInk copied to clipboard

Translation glitches

Open tiborepcek opened this issue 5 years ago • 9 comments

So i added PR with my slovak lng file and realized, there are few glitches: One string (Language) is not translatable and there is not enough space for whole strings in Options window for pens.

gInk-translation_glitches

tiborepcek avatar Oct 09 '19 10:10 tiborepcek

Thank you tiborepcek.

For the first glitch (the un-translatable string), I consider that not a string but an icon, i.e. an icon meaning "language". I don't think it is a real word in any language. I borrowed that icon from wikipedia, in belief that it could be understood by most people as meaning "language". But I'm not sure. Do you think people could understand that icon?

For the second glitch (cut-off string), I need to fix that, but now I'm not sure how to make enough space for them without changing the layout too much.

geovens avatar Oct 09 '19 11:10 geovens

Well, i did not understand that icon. :) If you show all other information as text, i assume, you should show "Language" as text too.

OK, it is not that bat. People can for sure understand those 2 words even without that missing small part in the end. :) But in the future, it would by nice, when you could fix it.

tiborepcek avatar Oct 09 '19 11:10 tiborepcek

OK, so I guess non-English speaking people would be more familiar with "Language" than that icon. I will change that to "Language". And sure I will fix the latter glitch.

geovens avatar Oct 09 '19 12:10 geovens

I have fixed them and released a new version with your translation.

geovens avatar Oct 10 '19 02:10 geovens

Thank you for you work.

I realized, that after choosing Slovak language, everything works fine, but after gInk restart, there is English language set back again. I had to manually add to config.ini Language_File = sk. I think, gInk could add this automatically if it is missing in config.ini file. What do you think?

tiborepcek avatar Oct 10 '19 07:10 tiborepcek

Oh, that line was missing in your config.ini? But I don't understand how it was missing. Were you mixing files from old and new versions?

geovens avatar Oct 10 '19 08:10 geovens

I did not overwrite it from downloaded zip file, because my config.ini file includes my custom settings. :)

tiborepcek avatar Oct 10 '19 08:10 tiborepcek

OK, so for new users it's not a problem, but it may be inconvenient for current users. Implementing the feature of auto adding individual lines in the ini files may take a bit more time than I'd like to though.

geovens avatar Oct 10 '19 10:10 geovens

Snapshot notification language not updated after changing language.

geovens avatar Oct 11 '19 12:10 geovens