gInk icon indicating copy to clipboard operation
gInk copied to clipboard

CallForm Proposal

Open pubpub-zz opened this issue 6 years ago • 2 comments

Hi Geovens,

This is a new feature I would like to propose you. When you are working without keyboard and on a full screen, starting annotation may not be easy. I've developped this proposal : a semi transparent icon will be displayed on screen. It dissappears when starting drawing and come back when complete. the windows can be move/dragg/ed with right click. default position,size,opacity are defined in the config.ini.

Tell me if you like it. Gink-ModCallBtn.zip

pubpub-zz avatar Oct 08 '18 02:10 pubpub-zz

Hi Geovens, any problem with this improvement ?

pubpub-zz avatar Nov 12 '18 20:11 pubpub-zz

I think that an optional floating button to activate drawing is a good idea. First, It's not easy to merge your change to the current master branch. It is based on your diverged branch of code which includes your previous modifications that are unrelated to the feature, thus it has been a bit too different to the current master branch. The code framework also chenged greatly when you implemented your code beside the Root class. Your zip file is not complete so that I can't build it as is. Seems that a button image is missing. I added a button image and built successfully, and I can see your idea get somewhat functional, but weird things still happen under different circumstances. A pull request with a full implementation is a better way for us. Second, and most importantly, I think that it added too much of complexity to the code. Even if could make a perfect implementation for now, the maintainness difficulty will rise too much for futher. I think that it's not worth it. Thank you for the great idea but I discourage you continuing doing it.

geovens avatar Nov 14 '18 12:11 geovens