geotools icon indicating copy to clipboard operation
geotools copied to clipboard

[WiP] Update jaxb to jakarta

Open Charmatzis opened this issue 1 year ago • 4 comments

Update jaxb to jakarta Following this https://docs.openrewrite.org/recipes/java/migrate/jakarta/javaxxmlbindmigrationtojakartaxmlbind

Charmatzis avatar Jul 10 '24 09:07 Charmatzis

If you want to get rid of the old jaxb fully, I believe you'll also have to upgrade upstream projects, for example, imageio-ext depends on it here: https://github.com/geosolutions-it/imageio-ext/blob/master/library/geocore/pom.xml

(don't remember if it's used anywhere else in imageio-ext, it might).

aaime avatar Jul 10 '24 09:07 aaime

@aaime true, thx. I will and come back

Charmatzis avatar Jul 10 '24 10:07 Charmatzis

Raised a PR for imageio-ext https://github.com/geosolutions-it/imageio-ext/pull/307

Charmatzis avatar Jul 10 '24 10:07 Charmatzis

Another bit that is troublesome, is that GeoServer is also using jaxb in a number of modules, both in supported land, and amongst the community modules. All these projects move as one (as you can see from the "downstream integration build") so the upgrade needs to be performed end-to-end.

Also a note, I've found down in the imageio-ext build that the jars require at least java 11. Can you confirm, and in particular, make sure that Java 17 is not required? The "geo-trio" (GeoTools, GeoWebCache and GeoServer) will eventually start requiring Java 17 to build, but for now, the build must run with Java 11.

Also, I see jakarta packages being used... we do have a plan to support Jakarta EE, but it will require lot of work and it's currently lacking funds to be implemented (so don't rely on the dates reported, we are already past them): https://github.com/geoserver/geoserver/wiki/Jakarta-EE

I've been looking at the dependencies for the new jars and it does not seem like any Java 17 or any Jakarta EE bit is required, but we need to make sure that's the case. Can you confirm?

aaime avatar Jul 15 '24 10:07 aaime

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 09 '24 15:11 stale[bot]

This issue has been automatically closed because it has not had recent activity. Please re-submit with updates if you want to resume work on this topic. Thank you for your contributions.

stale[bot] avatar Nov 23 '24 19:11 stale[bot]