geotiff.js icon indicating copy to clipboard operation
geotiff.js copied to clipboard

Regression in 1.0.0-beta.11

Open eliask opened this issue 4 years ago • 4 comments

I tried building cog-explorer from source and it turned out to have installed the latest version of geotiff.js. None of the sample GeoTIFF scenes worked, and it turned out that all of them triggered GeoTIFFImageIndexError somehow.

I didn't explore this further at this time. Downgrading to 1.0.0-beta.10 worked.

eliask avatar May 05 '20 14:05 eliask

Hi @eliask

Thanks for reporting this issue. Can you provide a URL where the parsing failed? I'll investigate.

constantinius avatar May 05 '20 15:05 constantinius

Hey,

It's these ones from the COG explorer samples:

  • https://landsat-pds.s3.amazonaws.com/c1/L8/189/027/LC08_L1TP_189027_20170403_20170414_01_T1/index.html (perhaps the multi-file handling is just broken here due to bitrot in COG explorer but that's not the case for the rest)
  • https://s3-us-west-2.amazonaws.com/planet-disaster-data/hurricane-harvey/SkySat_Freeport_s03_20170831T162740Z3.tif
  • https://oin-hotosm.s3.amazonaws.com/56f9b5a963ebf4bc00074e70/0/56f9c2d42b67227a79b4faec.tif

So I'm getting these ones (this one is for the first one):

TypeError: this.mainFile.parseFileDirectories is not a function
app.bundle.js line 4915 > eval:623:37

And the latter ones (this is just in the openlayers part, yes, but I think the real error manifests later)

TypeError: coordinates must be finite numbers
app.bundle.js line 8336 > eval:11:11
    checkCoord checkSanity.js:10
    default checkSanity.js:2
    transform transform.js:17
    transformer core.js:8
    inverse core.js:77
    createTransformFromCoordinateTransform proj.js:248
    getPointResolution proj.js:92
    calculateSourceResolution reproj.js:45

Additionally, when I add a try-catch block around the use of renderTile in cog-explorer mapview.jsx in renderTileInternal, I get the previously mentioned errors for the latter two images:

Error: "No image at index 6"
    GeoTIFFImageIndexError geotiff.js:155
    requestIFD/this.ifdRequests[index]< geotiff.js:432

eliask avatar May 07 '20 20:05 eliask

Okay, thanks, I'll check with the images provided. I just need to figure out how to build again, as it seems the building is broken with the latest version.

constantinius avatar May 08 '20 08:05 constantinius

@eliask

Is this still applicable with the latest version?

constantinius avatar Mar 30 '21 08:03 constantinius