MapStore2 icon indicating copy to clipboard operation
MapStore2 copied to clipboard

many plugins are disabled in cesium mode

Open landryb opened this issue 2 years ago • 1 comments

Description

i dunno if it's on purpose or if only testing is required to enable those plugins, but many of them are disabled in cesium mode, and while it would make sense for some (eg ZoomIn/ZoomOut ?) for some i dont understand why:

web/client/plugins/Annotations.jsx:        disablePluginIf: "{state('mapType') === 'cesium' || state('mapType') === 'leaflet' }"
web/client/plugins/Locate.jsx:        disablePluginIf: "{state('mapType') === 'cesium'}"
web/client/plugins/MapExport.jsx:        disablePluginIf: "{state('mapType') === 'cesium'}",
web/client/plugins/MapImport.jsx:        disablePluginIf: "{state('mapType') === 'cesium'}",
web/client/plugins/Measure.jsx:        disablePluginIf: "{state('mapType') === 'cesium'}",
web/client/plugins/Print.jsx:        disablePluginIf: "{state('mapType') === 'cesium' || !state('printEnabled')}",
web/client/plugins/ScaleBox.jsx:        disablePluginIf: "{state('mapType') === 'cesium'}"
web/client/plugins/ShapeFile.jsx:            disablePluginIf: "{state('mapType') === 'cesium'}"
web/client/plugins/StreetView/StreetView.jsx:            disablePluginIf: "{state('mapType') === 'leaflet' || state('mapType') === 'cesium'}"
web/client/plugins/Swipe.jsx:            disablePluginIf: "{state('mapType') === 'leaflet' || state('mapType') === 'cesium'}"
web/client/plugins/Timeline.jsx:        disablePluginIf: "{state('mapType') === 'cesium'}",
web/client/plugins/ZoomIn.jsx:        disablePluginIf: "{state('mapType') === 'cesium'}",
web/client/plugins/ZoomOut.jsx:        disablePluginIf: "{state('mapType') === 'cesium'}",

right now if i want to export a map with a 3d tiles layer, i need to go back to 2d mode and use MapExport plugin.

What kind of improvement you want to add? (check one with "x", remove the others)

  • [X] Minor changes to existing features

Other useful information

landryb avatar Apr 06 '22 09:04 landryb

  • measure tool is already handled by geosolutions-it/MapStore2#8489
  • map import/export is already handled by geosolutions-it/MapStore2#8351 (while its unclear to me if the testing was on importing maps or only geojson/shapefile)

landryb avatar Oct 13 '22 14:10 landryb

i've retested cesium on 2022.02:

  • zoomin/zoomout dont make sense as there's the cesium gyroscope control displayed already
  • annotations in 3d will probably be handled in a distinct issue, same for printing i guess
  • scalebox doesnt make sense in 3d
  • import/export map works, but the camera position doesnt seem correct

so this one can be closed for now.

landryb avatar Dec 23 '22 13:12 landryb