MapStore2 icon indicating copy to clipboard operation
MapStore2 copied to clipboard

Dynamic implementation import for supports tools

Open offtherailz opened this issue 5 years ago • 2 comments

Description

Provide a system to load implementation for map libraries dynamically

  • [x] Locate plugin
  • [ ] Draw Support
  • [ ] Swipe
  • [ ] ...

What kind of improvement you want to add? (check one with "x", remove the others)

  • [ ] Minor changes to existing features
  • [ ] Code style update (formatting, local variables)
  • [x] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Other... Please describe:

Other useful information

offtherailz avatar Oct 13 '20 16:10 offtherailz

We have first of all close #6111 and then finalize the review of #6006. then we will create new issues (collected in a Epic) for the other missing parts (eg Draw Support, Swipe etc).

tdipisa avatar Oct 30 '20 14:10 tdipisa

@tdipisa just merged the PR related issue #6111 'New configuration property for Locate tool'. With the current implementation the configuration for maxZoom is located in toolOpttions of Map plugin:

[
    {
        "name": "Map",
        "cfg": {
            ...,
            "toolsOptions": {
                "locate": {
                    "maxZoom": 5
                }
            }
        }
    },
    { "name": "Locate" }
]

we should fix the proposed implementation in #6006 'refactor of the Locate plugin to be used as a Map subplugin' with the new configuration and options that should be moved in Locate plugin:

[
  {
    "name": "Locate",
    "cfg": {
      "maxZoom": 5
    }
  }
]

allyoucanmap avatar Nov 02 '20 14:11 allyoucanmap