geoserver icon indicating copy to clipboard operation
geoserver copied to clipboard

[GEOS-11847] Next link is missing in "Search" OGC API - Features proposal implementation when startIndex is not set

Open sebastianfrey opened this issue 6 months ago • 2 comments

GEOS-11847 Powered by Pull Request Badge

If a POST request is executed against the experimental /search resource in the OGC API plugin, the next link indicating the next page of features is missing in the response, if startIndex is not specified. This PR fixes this behavior by providing a default value for startIndex parameter.

Checklist

  • [x] I have read the contribution guidelines.
  • [x] I have sent a Contribution Licence Agreement (not required for small changes, e.g., fixing typos in documentation).
  • [x] First PR targets the main branch (backports managed later; ignore for branch specific issues).

For core and extension modules:

  • [x] New unit tests have been added covering the changes.
  • [ ] Documentation has been updated (if change is visible to end users).
  • [ ] The REST API docs have been updated (when changing configuration objects or the REST controllers).
  • [x] There is an issue in the GeoServer Jira (except for changes that do not affect administrators or end users in any way).
  • [x] Commit message(s) must be in the form [GEOS-XYZWV] Title of the Jira ticket.
  • [x] Bug fixes and small new features are presented as a single commit.
  • [ ] Each commit has a single objective (if there are multiple commits, each has a separate JIRA ticket describing its goal).

The PR will be merged when all the build checks are green (see automated QA checks), there is a code committer review, and the checklist has been fulfilled.

sebastianfrey avatar May 30 '25 09:05 sebastianfrey

The failed tests on Mac OS and Linux JDK 21 seem unrelated to changes made in this PR

sebastianfrey avatar May 30 '25 11:05 sebastianfrey

Cherry pick into 2.26.x would be appreciated

sebastianfrey avatar Jun 02 '25 06:06 sebastianfrey

LGTM.

aaime avatar Jul 07 '25 09:07 aaime

@sebastianfrey I've tried to schedule a backport to 2.26.x but there are some API differences, a manual backport is required. See also: https://github.com/geoserver/geoserver/pull/8659

aaime avatar Jul 07 '25 12:07 aaime

@aaime Thank you for letting me know. I've created a second PR, which manually backports the fix to 2.26.x.

sebastianfrey avatar Jul 07 '25 14:07 sebastianfrey