integrated_methane_inversion icon indicating copy to clipboard operation
integrated_methane_inversion copied to clipboard

Statevector defined domain is truncated by buffer zone in nested regions.

Open laestrada opened this issue 2 years ago • 3 comments

Name and Institution (Required)

Name: Lucas Estrada Institution: Harvard ACMG

Description of your issue or question

Name and Institution (Required)

Name: Lucas Estrada Institution: Harvard ACMG

New IMI feature or discussion

Currently GEOS-Chem defines the statevector max/min lat and lon grid centers as the domain edges. But because of the nested domain buffer zone, 3-4 grid cells get chopped off on each side of the domain. This can be misleading for users because the outputted domain is different from the inputted lats/lons.

To fix this issue we should add a function that takes the user-defined statevector and pads it with 3 gridcells (labeled with 0 to prevent additional jacobian simulations). This function should also check whether the buffer-zone gridcells have already been added to the domain to prevent unexpected bloat of the domain when repeatedly running the IMI.

This should not be an issue for most users as long as they are using sufficient large buffer elements surrounding their domain of interest.

laestrada avatar Jun 15 '23 17:06 laestrada

This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days it will be closed. You can add the "never stale" tag to prevent the issue from closing this issue.

github-actions[bot] avatar Mar 21 '24 01:03 github-actions[bot]

@laestrada Is this still an issue?

msulprizio avatar Mar 21 '24 13:03 msulprizio

@msulprizio I believe this is still an issue

laestrada avatar Mar 28 '24 13:03 laestrada

This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days it will be closed. You can add the "never stale" tag to prevent the issue from closing this issue.

github-actions[bot] avatar Sep 25 '24 01:09 github-actions[bot]

Closing due to inactivity

github-actions[bot] avatar Oct 03 '24 01:10 github-actions[bot]