geos-chem icon indicating copy to clipboard operation
geos-chem copied to clipboard

OCPISOA and TotalOC not correctly represented in benchmark

Open yuanjianz opened this issue 8 months ago • 2 comments

Your name

Yuanjian Zhang

Your affiliation

WashU

What happened? What did you expect to happen?

OCPISOA

OCPISOA in benchmark simulation (simpleSOA and complexSOA are both carried) double counts ISOAAQ as was in PM2.5. https://github.com/geoschem/geos-chem/blob/1ef3d7f88da95ca2425267fc4f96bd1524fc985f/GeosCore/aerosol_mod.F90#L764-L799 ISOAAQ should be added inside the elseif above to avoid this double-counting.

TotalOC

TotalOC only includes Isoprene SOA OC in complexSOA_nonSVPOA, where both POA and OPOA are not present. https://github.com/geoschem/geos-chem/blob/1ef3d7f88da95ca2425267fc4f96bd1524fc985f/GeosCore/diagnostics_mod.F90#L2189-L2200 It should match what is happening in aerosol_mod.F90 https://github.com/geoschem/geos-chem/blob/1ef3d7f88da95ca2425267fc4f96bd1524fc985f/GeosCore/aerosol_mod.F90#L502-L511

What are the steps to reproduce the bug?

run a fullchem benchmark simulation

Please attach any relevant configuration and log files.

No response

What GEOS-Chem version were you using?

14.4.0

What environment were you running GEOS-Chem on?

Local cluster

What compiler and version were you using?

gcc 10.2.0

Will you be addressing this bug yourself?

Yes

In what configuration were you running GEOS-Chem?

Other (please explain in additional information section below)

What simulation were you running?

Full chemistry

As what resolution were you running GEOS-Chem?

N/A

What meterology fields did you use?

Other (please explain in additional information section below)

Additional information

No response

yuanjianz avatar Jun 12 '24 05:06 yuanjianz