geocoding icon indicating copy to clipboard operation
geocoding copied to clipboard
verified publisher icon georust

Remove reqwest default tls feature

Open flosse opened this issue 3 years ago • 4 comments

  • [x] I agree to follow the project's code of conduct.
  • [x] I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

flosse avatar Aug 29 '22 11:08 flosse

r? @urschrei

lnicola avatar Feb 13 '23 08:02 lnicola

This will need a rebase when #57 merges, right?

urschrei avatar Feb 13 '23 10:02 urschrei

The chrono work was just merged in https://github.com/georust/geocoding/pull/60 so this will at least need a rebase.

But also... what is this PR doing? Is it disabling TLS? Why would we want that?

michaelkirk avatar Oct 05 '23 04:10 michaelkirk

Oh, I think I understand.

We want people to be able to choose their tls backend, which are already exposed by geocoding features:

[features]
default = ["reqwest/default"] # this builds default-tls
rustls-tls = ["reqwest/rustls-tls"] # this builds rust-tls

But we were erroneously (redundantly) declaring that reqwest always builds default-tls, so there was no way to use only rust-tls without this PR. Is that right?

michaelkirk avatar Oct 05 '23 04:10 michaelkirk