Georgi Dimitrov
Georgi Dimitrov
Hi @uno4ki, I'm happy to review this. Would you mind bringing the branch up-to-date with master?
Hi, I noticed the `Run Tests / macos-latest @ Go 1.19 -tags "sonic avx" (pull_request)` CI job failed. It appears that it expects fewer mallocs: ``` === RUN TestPathCleanMallocs path_test.go:85:...
Sure. Here are the results of running the following command: ```sh go test -bench=. -run '^Benchmark.*$' -count 10 ``` - [master.txt](https://github.com/gin-gonic/gin/files/13592033/master.txt) - [fix-missing-params.txt](https://github.com/gin-gonic/gin/files/13592006/fix-missing-params.txt) and the comparison: ```sh $ benchstat master.txt...
Hi, Any updates on this?
I would also like to add that this code (not the PR itself) would override the `haproxyOptions.MasterRuntime` even if the environment variable is not set: https://github.com/haproxytech/dataplaneapi/blob/2e6d65889706f9c0553e4083edd99d829e0062f5/configure_data_plane.go#L123-L124 because `misc.IsUnixSocket` returns `true`...
Hi everyone, Any updates on this?